Update objective computation: multiply quadratic biases with (1-alpha)#18
Open
aivarsoo wants to merge 4 commits intodwavesystems:mainfrom
Open
Update objective computation: multiply quadratic biases with (1-alpha)#18aivarsoo wants to merge 4 commits intodwavesystems:mainfrom
aivarsoo wants to merge 4 commits intodwavesystems:mainfrom
Conversation
Member
|
Looks like the CI failures are not related to this PR. I will fix in a followup. |
arcondello
reviewed
Mar 18, 2024
Member
arcondello
left a comment
arcondello
left a comment
There was a problem hiding this comment.
It would also be good to have a test that confirms that at the extreme ends of alpha we get what we expect.
| # copying the correlations with the target column | ||
| target_correlations = correlations[:, -1].copy() | ||
| # multiplying all terms with (1 - alpha) | ||
| np.multiply(correlations, (1 - alpha), out=correlations) |
Member
There was a problem hiding this comment.
Rather than saving a separate target_correlations array, why not just
Suggested change
| np.multiply(correlations, (1 - alpha), out=correlations) | |
| np.multiply(correlations[:-1, :-1], (1 - alpha), out=correlations) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation is not consistent with the documentation, which states that:
Closes #17
To make the docs consistent with the code, we change the code and multiply the off-diagonal terms of the objective matrix (or quadratic biases) with
1-alpha